[Lldb-commits] [PATCH] D46726: build: use cmake to find the libedit content

Saleem Abdulrasool via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Sun Jun 3 18:06:06 PDT 2018

compnerd added inline comments.

Comment at: scripts/Python/modules/readline/CMakeLists.txt:11
+                           PRIVATE
+                             ${libedit_INCLUDE_DIRS})
lonico77 wrote:
> Should this be under  if (NOT LLDB_DISABLE_LIBEDIT)  ?
> I'm seeing 
> CMake Error: The following variables are used in this project, but they are set to NOTFOUND.
> Please set them or make sure they are set and tested correctly in the CMake files:
> /x/eng/rtpbld01/scratch/laurentn/llvm-wss/sources/llvm_import_from_git_rtp3/llvm/tools/lldb/scripts/Python/modules/readline/libedit_INCLUDE_DIRS
> used as include directory in directory /x/eng/rtpbld01/scratch/laurentn/llvm-wss/sources/llvm_import_from_git_rtp3/llvm/tools/lldb/scripts/Python/modules/readline
Yeah, it should be under the condition.  I'll patch that soon.


More information about the lldb-commits mailing list