[Lldb-commits] [PATCH] D47679: [lldb, lldb-mi] Enable lldb-mi -break-insert test on Windows.

Stella Stamenova via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Sun Jun 3 08:17:18 PDT 2018


stella.stamenova added a comment.

In https://reviews.llvm.org/D47679#1120177, @polyakov.alex wrote:

> In https://reviews.llvm.org/D47679#1120172, @stella.stamenova wrote:
>
> > In https://reviews.llvm.org/D47679#1120081, @polyakov.alex wrote:
> >
> > > Due to https://reviews.llvm.org/D47678 we can enable this test with a XFAIL directive for Windows.
> >
> >
> > Not true. As I said, the original review when I disabled the test has the log of what happens when you give it the correct path and the test still hangs in that scenario. If you XFAIL it, it will hang.
>
>
> Yep, I got the same on Linux. But if you run it through llvm-lit(not `lldb-mi < input-file`) it won't hang.


I can apply your change locally on Monday and double-check. You have to remember that the behavior of the tools and test suite is not exactly the same on Linux and Windows.


https://reviews.llvm.org/D47679





More information about the lldb-commits mailing list