[Lldb-commits] [PATCH] D47679: [lldb, lldb-mi] Enable lldb-mi -break-insert test on Windows.

Stella Stamenova via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Sun Jun 3 07:57:42 PDT 2018

stella.stamenova added a comment.

In https://reviews.llvm.org/D47679#1120081, @polyakov.alex wrote:

> Due to https://reviews.llvm.org/D47678 we can enable this test with a XFAIL directive for Windows.

Not true. As I said, the original review when I disabled the test has the log of what happens when you give it the correct path and the test still hangs in that scenario. If you XFAIL it, it will hang.

@aprantl There is currently no public not that runs the tests. The one you found just builds but runs no tests. I have a machine I am going to add as a bot but there are still a lot of failing tests, so I don’t want to add it yet as it will be just noise until the tests are fixed or disabled.

In https://reviews.llvm.org/D47679#1120166, @aprantl wrote:

> Stella, is there a public bot that runs the tests on Windows that we could watch? I found http://lab.llvm.org:8011/builders/lldb-x86-windows-msvc2015?numbuilds=1000 but it doesn't look like that one actually failed with the error you saw.

Comment at: lit/tools/lldb-mi/breakpoint/break-insert.test:1
-# REQUIRES: nowindows
+# XFAIL: windows
 # -> llvm.org/pr24452
aprantl wrote:
> Do we still expect the test to fail after this change?
It will still fail and it will still hang.


More information about the lldb-commits mailing list