[Lldb-commits] [PATCH] D47679: [lldb, lldb-mi] Enable lldb-mi -break-insert test on Windows.

Stella Stamenova via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Sat Jun 2 15:51:16 PDT 2018

stella.stamenova added a comment.

You can actually follow the pattern in the other tests and do:

  %cc -o %t %p/inputs/break-insert.c -g

  %t``` then becomes the name of the output file and you can use that in our other commands. This is better than specifying a hardcoded name.
  Having said that, I believe this won't fix the test. If you look at the comments of the review when I disabled the test, there is output of what happens when you give it the correct name - which is to run until the program exits *normally* rather than hitting a breakpoint as the test expects. After the program exits normally, lldb-mi just waits and the test will hang. Your other change will address the issue of the test hanging when it's given the incorrect file name, but I don't think it will fix this case.



More information about the lldb-commits mailing list