[Lldb-commits] [PATCH] D40470: Protect DWARFCompileUnit::m_die_array by a new mutex

[Jan Kratochvil via Phabricator via lldb-commits]

jankratochvil updated this revision to Diff 149609.
jankratochvil added a comment.

Provided variants with a new RAII lock guard vs. unchanged caller `bool clear_dies` variable. And also 1 vs. 2 mutexes for `m_die_array`. Please choose one, I do not mind any.

- mutexes2raii.patch <https://people.redhat.com/jkratoch/mutexes2raii.patch> - RAII lock guard, 2 mutexes - preferred by me, posted here
- mutexes2var.patch <https://people.redhat.com/jkratoch/mutexes2var.patch> - caller variable, 2 mutexes
- mutexes1raii.patch <https://people.redhat.com/jkratoch/mutexes1raii.patch> - RAII lock guard, 1 mutex (lock retrying)
- mutexes1var.patch <https://people.redhat.com/jkratoch/mutexes1var.patch> - caller variable, 1 mutex (lock retrying)  - IMO this was suggested by you


https://reviews.llvm.org/D40470

Files:
  source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp
  source/Plugins/SymbolFile/DWARF/DWARFUnit.h
  source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D40470.149609.patch
Type: text/x-patch
Size: 11583 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20180602/c2750f24/attachment.bin>