[Lldb-commits] [PATCH] D47625: [cmake] Detect presence of wide-char libedit at build time

[Pavel Labath via Phabricator via lldb-commits]

labath added inline comments.


================
Comment at: include/lldb/Host/Editline.h:72-76
 #ifdef EL_CLIENTDATA	/* editline with wide support + wide char read function */
 using EditLineGetCharType = wchar_t;
 #else
 using EditLineGetCharType = char;
 #endif
----------------
It's not fully clear to me whether this part is still correct. My understanding is that if we use `el_wset` to set the getchar callback, we should always use wchar_t, regardless of libedit version. This is only true if all wide-char capable libedit versions also define EL_CLIENTDATA.

Is this the case?


https://reviews.llvm.org/D47625