[Lldb-commits] [PATCH] D47470: AppleDWARFIndex: Get function method-ness directly from debug info

[Pavel Labath via Phabricator via lldb-commits]

labath updated this revision to Diff 149423.
labath marked an inline comment as done.
labath added a comment.

I have a feeling we are starting to over-engineer this. Visiting referenced dies
sounds like a useful utility in general, though I think most of the users will
be content with just visiting the attributes of those dies (and that's a
functionality we already have). Nonetheless, I implemented something like that.
I made it an iterator-based api, as callback-based apis are generally more
complicated to use.


https://reviews.llvm.org/D47470

Files:
  lit/SymbolFile/DWARF/find-method-local-struct.cpp
  source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cpp
  source/Plugins/SymbolFile/DWARF/DWARFDIE.cpp
  source/Plugins/SymbolFile/DWARF/DWARFDIE.h
  source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D47470.149423.patch
Type: text/x-patch
Size: 9724 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20180601/30105e0e/attachment-0001.bin>