[Lldb-commits] [PATCH] D47579: dotest: make inline tests compatible with -f

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu May 31 03:37:18 PDT 2018

JDevlieghere added a comment.

If I correctly understand this change, this might make it possible to apply the `add_test_categories` decorator to an inline test. We had issues with this when introducing the swiftpr category because the methods were part of the inline test class. From the description I get the idea that now they become part of the individual instantiations? I **really** hope this is the case :-)

Regardless of my (potential) excitement, this looks good to me!

Comment at: packages/Python/lldbsuite/test/lldbinline.py:139
+    def _test(self):
         self.using_dsym = True
Will the decorators ensure that this value is properly set (or ignored) for the non-dsym tests? 


More information about the lldb-commits mailing list