[Lldb-commits] [PATCH] D47539: [Platform] Accept arbitrary kext variants

Jason Molenda via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed May 30 18:38:23 PDT 2018

jasonmolenda added a comment.

LGTM.  If we added more knowledge specifically about kext bundle layouts, we could restrict which files we test to see if they are valid binaries - but we'd need to parse the Info.plist at the top (to get the CFBundleExecutable name, and look for variations on that prefix) and we'd need to handle shallow/deep kext bundles.  Given how few files are in kext bundles besides the kexts themselves (a couple of plists), this is code is much simpler than encoding all that extra specifics about kexts.


More information about the lldb-commits mailing list