[Lldb-commits] [PATCH] D47508: [lldb-test] Add a testing harness for the JIT's IRMemoryMap
Vedant Kumar via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed May 30 11:55:14 PDT 2018
vsk updated this revision to Diff 149173.
vsk edited the summary of this revision.
vsk added a comment.
- Really fix the allocation overlap test. The previous version of this patch would not detect overlaps in which the end of the new allocation is contained within an existing allocation.
> The idea that came to me while looking at this is testing this gdb-client style. This would allow you to mock the server responses to allocation and e.g. test handling of allocation failures. However, the problem is these tests sit on top of SBAPI and there seems to be no way to issue "raw" allocation requests through that (although maybe there is a case to be made for SBProcess.AllocateMemory as a generally useful API).
> However, if this does the job you want, then I'm fine with that too.
Testing at this level looks to be sufficient to uncover the bugs I'm concerned about, so I'd prefer not to extend the SB API if possible.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 11566 bytes
Desc: not available
More information about the lldb-commits