[Lldb-commits] [PATCH] D47495: Support relative paths with less than two components in DBGSourcePathRemapping

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue May 29 14:43:48 PDT 2018

JDevlieghere added inline comments.

Comment at: include/lldb/Utility/FileSpec.h:535
-  void RemoveLastPathComponent();
+  void RemoveLastPathComponent(bool keep_dot = false);
clayborg wrote:
> Why add this? If the path is just "." to begin with, there is nothing to do. I would vote to not add this argument since we don't need it. Add it back if we ever do.
The reason I opted for a flag rather than changing the behavior is that other (llvm & foundation) implementation of similar functions behave the same as the current implementation. However I think an argument can be made for this as well, so I'm happy to change it :-) 


More information about the lldb-commits mailing list