[Lldb-commits] [PATCH] D46810: 3/3: Fix DWARFUnit::GetUnitDIEPtrOnly stale pointer
Alex Langford via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue May 29 11:51:52 PDT 2018
xiaobai added inline comments.
================
Comment at: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:208
+void DWARFUnit::ExtractDIEsEndCheck(lldb::offset_t offset) const {
+ lldb::offset_t next_cu_offset = GetNextCompileUnitOffset();
+
----------------
This function introduces a warning because `next_cu_offset` is never used within this function. Did you intend to use it in the if conditional below? It looks like you call `GetNextCompileUnitOffset` there instead of using `next_cu_offset`.
Repository:
rL LLVM
https://reviews.llvm.org/D46810
More information about the lldb-commits
mailing list