[Lldb-commits] [PATCH] D46810: 3/3: Fix DWARFUnit::GetUnitDIEPtrOnly stale pointer

Greg Clayton via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue May 29 09:26:24 PDT 2018

clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.

Only question is if we remove the extra empty scope as noted in inline comments. Looks good.

Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:86
   // Keep a flat array of the DIE for binary lookup by DIE offset
-  if (!cu_die_only) {
+  {
     Log *log(
Do we need this empty scope? Remove?


More information about the lldb-commits mailing list