[Lldb-commits] [PATCH] D47384: Remove dependency from Host to clang

[Zachary Turner via Phabricator via lldb-commits]

zturner created this revision.
zturner added reviewers: labath, davide.
Herald added a subscriber: mgorny.

The idea is to move the discovery of the clang resource directory into a more appropriate place, such as the clang expression parser.  By continuing with this pattern we can isolate all clang interactions to the clang expression parser.  There is a little edge case here in that there is a public enumeration which is used in conjunction with `SBHostOS` to get a generic LLDB directory.  So as not to break the public API, I just special case this particular value of the enumeration and don't pass it through to Host, rather passing it through to the clang expression parser plugin.

I'm not able to test this on OSX, so I expect there may be some easy to fix up compilation errors.  Davide, would you mind helping me out with that?


https://reviews.llvm.org/D47384

Files:
  lldb/include/lldb/Host/HostInfoBase.h
  lldb/include/lldb/Host/macosx/HostInfoMacOSX.h
  lldb/include/lldb/Host/posix/HostInfoPosix.h
  lldb/source/API/SBHostOS.cpp
  lldb/source/Host/common/HostInfoBase.cpp
  lldb/source/Host/macosx/HostInfoMacOSX.mm
  lldb/source/Host/posix/HostInfoPosix.cpp
  lldb/source/Plugins/ExpressionParser/Clang/CMakeLists.txt
  lldb/source/Plugins/ExpressionParser/Clang/ClangHost.cpp
  lldb/source/Plugins/ExpressionParser/Clang/ClangHost.h
  lldb/source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.cpp
  lldb/unittests/Host/HostInfoTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D47384.148640.patch
Type: text/x-patch
Size: 20193 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20180525/9190be6f/attachment-0001.bin>