[Lldb-commits] [PATCH] D47232: Break dependency from Expression -> Commands

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

Both of the solutions sound plausible to me (extra struct vs. moving REPL to `Command`). Maybe that's because I don't know enough about the REPL to have formed an opinion on it.



================
Comment at: lldb/include/lldb/Expression/REPL.h:31
+    bool TryAllThreads = true;
+    uint32_t Timeout = 0;
+  };
----------------
If you stick with this solution, please make this `Timeout<std::micro>`


https://reviews.llvm.org/D47232