[Lldb-commits] [PATCH] D46889: [DWARF] Extract indexing code into a separate class hierarchy

[Adrian Prantl via lldb-commits]

> On May 18, 2018, at 11:25 AM, Amara Emerson via Phabricator <reviews at reviews.llvm.org> wrote:
> 
> aemerson added a comment.
> 
> In https://reviews.llvm.org/D46889#1104823, @aprantl wrote:
> 
>> Thanks for jumping on this Amara — I just wanted to point out that we ususally don't revert lldb changes that only break the lldb-xcode bot if they pass on the lldb-cmake bot at the same time. When this happens it usually means that the lldb Xcode project must be updated and it's too much to ask from all open source contributors to get access to a machine running Xcode to do this. Instead one of the Apple LLDB developers usually goes in and updates the Xcode project for them.
>> 
>> - adrian
> 
> 
> Ah ok. Does that include cases like this one with the link error:

Possibly not.. I just realized that the lldb-cmake bot was stuck. I changed the configuration to have a timeout and forced a clean rebuild.
-- adrian

> 
>  Undefined symbols for architecture x86_64:
>    "lldb_private::AppleDWARFIndex::Create(lldb_private::Module&, lldb_private::DWARFDataExtractor, lldb_private::DWARFDataExtractor, lldb_private::DWARFDataExtractor, lldb_private::DWARFDataExtractor, lldb_private::DWARFDataExtractor)", referenced from:
>        SymbolFileDWARF::InitializeObject() in liblldb-core.a(SymbolFileDWARF.o)
>    "vtable for lldb_private::ManualDWARFIndex", referenced from:
>        SymbolFileDWARF::InitializeObject() in liblldb-core.a(SymbolFileDWARF.o)
>    NOTE: a missing vtable usually means the first non-inline virtual member function has no definition.
> 
> 
> Repository:
>  rL LLVM
> 
> https://reviews.llvm.org/D46889
> 
> 
>