[Lldb-commits] [PATCH] D46889: [DWARF] Extract indexing code into a separate class hierarchy

Greg Clayton via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu May 17 08:35:26 PDT 2018


clayborg accepted this revision.
clayborg added inline comments.
This revision is now accepted and ready to land.


================
Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:1984
       GetObjectFile()->GetModule()->GetMutex());
-  Index();
-}
----------------
Yikes, who was calling PreloadSymbols before? Was this causing all Apple systems to manually index the DWARF as well??? That is bad. Fix now with you changes to the right, but scary.


https://reviews.llvm.org/D46889





More information about the lldb-commits mailing list