[Lldb-commits] [PATCH] D46934: Make ObjectFileMachO work on non-darwin platforms

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu May 17 04:13:04 PDT 2018


labath updated this revision to Diff 147286.
labath added a comment.

This is the version with new symbolic constants. I put them in a new file, as I
couldn't think of a better place for them.

I didn't want to put them in a too generic place as I don't think we should
encourage their use (we should convert error to one of our standard errors types
as soon as possible). On the other hand, they are used in two files, so they
can't be internal to a compilation unit. There wasn't anything reasonable in the
overlap of the existing includes of the two files, so I created a new file
instead.


https://reviews.llvm.org/D46934

Files:
  lit/Modules/lc_version_min.yaml
  source/Initialization/CMakeLists.txt
  source/Initialization/SystemInitializerCommon.cpp
  source/Plugins/Process/Utility/RegisterContextDarwinConstants.h
  source/Plugins/Process/Utility/RegisterContextDarwin_arm.cpp
  source/Plugins/Process/Utility/RegisterContextDarwin_arm64.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D46934.147286.patch
Type: text/x-patch
Size: 13974 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20180517/3d43fda4/attachment.bin>


More information about the lldb-commits mailing list