[Lldb-commits] [PATCH] D46588: [LLDB][lldb-mi] Add possibility to set breakpoints without selecting a target.

[Pavel Labath via Phabricator via lldb-commits]

labath added inline comments.


================
Comment at: lit/Breakpoint/Inputs/break-insert.input:1-3
+-break-insert breakpoint
+-file-exec-and-symbols a.out
+-exec-run
----------------
Based on my experiments, lldb-mi seems to ignore lines starting with `#`. If that's true then we could put the contents of this file directly in the test, which will help readability as there is only one file to open to understand what a test does.


================
Comment at: lit/Breakpoint/break-insert.test:1
+# RUN: %cc %p/Inputs/break-insert.c -g 
+# RUN: %lldb_mi < %p/Inputs/break-insert.input | FileCheck %s
----------------
I think the lldb-mi tests should be kept separate. Could we move this test into a different directory? Maybe `lit/tools/lldb-mi` ?


Repository:
  rL LLVM

https://reviews.llvm.org/D46588