[Lldb-commits] [PATCH] D46588: [LLDB][lldb-mi] Add possibility to set breakpoints without selecting a target.

[Adrian Prantl via Phabricator via lldb-commits]

aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

Thanks for converting the test!



================
Comment at: lit/Breakpoint/break-insert.test:2
+# RUN: %cc %p/Inputs/break-insert.c -g 
+# RUN: %lldb_mi < %p/Inputs/break-insert.input | FileCheck %s
+
----------------
Please add a comment like:
`# Test that a breakpoint can be inserted before creating a target.`



================
Comment at: lit/Breakpoint/break-insert.test:5
+# cmd: -break-insert breakpoint
+# CHECK: ^done,bkpt={number="1"
+
----------------
Very nice!

What does the actual output format of lldb-mi look like?
If every reply is on a single line, we could make this test even stricter by using `CHECK-NEXT` instead of `CHECK` to make sure that no other output appears between two matches. Alternatively you could also insert a `CHECK-NOT: ^done` line before every command to make the test even stricter.


Repository:
  rL LLVM

https://reviews.llvm.org/D46588