[Lldb-commits] [PATCH] D46726: build: use cmake to find the libedit content

[Saleem Abdulrasool via Phabricator via lldb-commits]

compnerd added inline comments.


================
Comment at: cmake/modules/FindLibEdit.cmake:11-14
+#   libedit_FOUND         - true if libedit was found
+#   libedit_INCLUDE_DIRS  - include search path
+#   libedit_LIBRARIES     - libraries to link
+#   libedit_VERSION       - version number
----------------
labath wrote:
> Should we make the capitalization of these match the file name (LibEdit_FOUND) ?
*shrug* I'm not tied to that.  I found `LibEdit_FOUND` to be a bit jarring, which is why I went with `libedit_FOUND` which also mirror's the project's actual spelling (`libedit`).


================
Comment at: cmake/modules/FindLibEdit.cmake:53-54
+    set(libedit_VERSION_STRING "${libedit_major_version}.${libedit_minor_version}")
+    unset(libedit_major_version)
+    unset(libedit_minor_version)
+  endif()
----------------
labath wrote:
> Do you really need to unset these? I would hope that this file is evaluated in a fresh context, and it won't pollute the callers namespace or anything..
I'm pretty sure that they get evaluated in the global context :-(.


https://reviews.llvm.org/D46726