[Lldb-commits] [PATCH] D46736: HostInfoMacOSX: Share the clang resource directory with Swift.
Frederic Riss via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Fri May 11 10:04:02 PDT 2018
friss accepted this revision.
friss added inline comments.
This revision is now accepted and ready to land.
================
Comment at: source/Host/macosx/HostInfoMacOSX.mm:288
+ // Fall back to the Clang resource directory inside the framework.
+ raw_path.resize(rev_it - r_end);
raw_path.append("/Resources/Clang");
----------------
As both branches above also resize, I think it would be clearer if this resize was in a final else above rather than on its own. Otherwise this LGTM
https://reviews.llvm.org/D46736
More information about the lldb-commits
mailing list