[Lldb-commits] [PATCH] D46733: Add a lock to PlatformPOSIX::DoLoadImage

[Frederic Riss via Phabricator via lldb-commits]

friss added inline comments.


================
Comment at: source/Plugins/Platform/POSIX/PlatformPOSIX.cpp:1046-1047
+  {
+    static std::mutex do_dlopen_mutex;
+    std::lock_guard<std::mutex> lock(do_dlopen_mutex);
+
----------------
clayborg wrote:
> We should put the mutex, or better yet a std::once_flag, in the process as an instance variable. The utility function belongs to each process.
I don't disagree, but it seemed a little overkill. Would you just put it as a public member? Or add a GetLoadImageUtilityFunctionOnceFlag() accessor?


https://reviews.llvm.org/D46733