[Lldb-commits] [PATCH] D46687: Remove custom path manipulation functions from FileSpec

[Greg Clayton via Phabricator via lldb-commits]

clayborg added inline comments.


================
Comment at: source/Utility/FileSpec.cpp:277-281
+  auto style = LLVMPathSyntax(syntax);
+  m_filename.SetString(llvm::sys::path::filename(resolved, style));
+  llvm::StringRef dir = llvm::sys::path::parent_path(resolved, style);
+  if (!dir.empty())
+    m_directory.SetString(dir);
----------------
Does this work ok in LLVM if the slashes have already been switched on line 275? We would specify a syntax of windows, but the slashes would be wrong?


https://reviews.llvm.org/D46687