[Lldb-commits] [PATCH] D46606: General cleanup to minimize the .debug_types patch

[Adrian Prantl via Phabricator via lldb-commits]

aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

Looks like this is bringing the interface a *little* closer to the llvm one.



================
Comment at: source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.h:40
+  //------------------------------------------------------------------
+  uint32_t GetHeaderByteSize() const override {
+    return m_is_dwarf64 ? 23 : 11;
----------------
Looking at the LLVM implementation, this is only correct fro DWARF 4.
Out of curiosity, do we have any plans to ever support DWARF 5 in LLDB's DWARF parser or are we planning to get that from moving to the LLVM implementation? (I'd clearly prefer the second option).


https://reviews.llvm.org/D46606