[Lldb-commits] [PATCH] D46576: [DWARF] Align non-accelerated function fullname searching with the apple-tables path

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

In https://reviews.llvm.org/D46576#1091548, @clayborg wrote:

> Before adding the DWARF 5 index support, we should virtualize this searching and indexing into a base class. Then we make 1 class for manual DWARF indexing, one for Apple indexes, and one for DWARF5. Then we can unit test each one easily. Thoughts?


Yes, that's exactly where I'm heading. I started doing that, but then I noticed that two of the existing paths were sometimes very different for no apparent reason. I'm trying to bring them closer together to make the interface of the index class saner.


https://reviews.llvm.org/D46576