[Lldb-commits] [PATCH] D46576: [DWARF] Align non-accelerated function fullname searching with the apple-tables path

[Greg Clayton via Phabricator via lldb-commits]

clayborg added a comment.

See inlined comments



================
Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:901-902
             Mangled mangled(ConstString(mangled_cstr), true);
+            func_basenames.Insert(mangled.GetMangledName(),
+                                  DIERef(cu_offset, die.GetOffset()));
             func_fullnames.Insert(mangled.GetMangledName(),
----------------
Why are we adding the mangled name to the basenames?


================
Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:905-908
             ConstString demangled = mangled.GetDemangledName(cu_language);
             if (demangled)
               func_fullnames.Insert(demangled,
                                     DIERef(cu_offset, die.GetOffset()));
----------------
Should we remove these 4 lines now? I thought we weren't going to add demangled names to the index?


================
Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:928-929
             Mangled mangled(ConstString(mangled_cstr), true);
+            func_basenames.Insert(mangled.GetMangledName(),
+                                  DIERef(cu_offset, die.GetOffset()));
             func_fullnames.Insert(mangled.GetMangledName(),
----------------
Why are we adding the mangled name to the basenames?


https://reviews.llvm.org/D46576