[Lldb-commits] [lldb] r331082 - Fix build bots after r331049 broke them.

[Davide Italiano via lldb-commits]

I would like to apologize for communicating this so late (mainly
because I worked on the swift bits which are a little behind and I
didn't update my checkout) but this commit completely broke debugging
in some cases (on MacOS).

Testcase:

#import <Foundation/Foundation.h>

int main() {
  id keys[1] = { @"abc" };
  id values[1] = { @"def" };
  id d = CFBridgingRelease(CFDictionaryCreate(nil, (void *)keys, (void
*)values, 1, nil, nil));
  NSLog(@"%@", d);
  NSLog(@"x");
}


$ clang patatino.m -framework Foundation -g -o blah


dtdebugger2:bin davide$ ./lldb ./blah
(lldb) target create "./blah"
Current executable set to './blah' (x86_64).
(lldb) b main
Breakpoint 1: where = blah`main + 13 at blah.c:2, address =
0x0000000100000fad
(lldb) r
error: No such file or directory

Reverting yours (and a later change to avoid conflicts):

dtdebugger2:llvm-project-20170507 davide$ git revert 57dce7084e7b
[master 8be66051362] Revert "Fixup r331049 (FileSpec
auto-normalization)"
2 files changed, 11 insertions(+), 5 deletions(-)
dtdebugger2:llvm-project-20170507 davide$ git revert
d5a834a73c0b37c3862daee260c416e7ea3b761c
[master 5bd1fb68a69] Revert "Fix build bots after r331049 broke them."
1 file changed, 10 insertions(+), 10 deletions(-)

works.
I also noticed that if I pass a full path the thing works:

Current executable set to
'/Users/davide/work/llvm-monorepo/build/bin/blah' (x86_64).
(lldb) b main
Breakpoint 1: where = blah`main + 13 at blah.c:2, address = 0x0000000100000fad
(lldb) r
Process 82833 launched:
'/Users/davide/work/llvm-monorepo/build/bin/blah' (x86_64)
Process 82833 stopped
* thread #1, queue = 'com.apple.main-thread', stop reason = breakpoint 1.1
    frame #0: 0x0000000100000fad blah`main at blah.c:2
   1    int main(void) {
-> 2      return 0;
   3    }


Do you mind to take a look and add a lit test for this?
(also, I guess you should change your mail address as it's still an @apple one).

Thanks!

--
Davide

On Thu, May 3, 2018 at 3:07 PM, Davide Italiano <dccitaliano at gmail.com> wrote:
> On Fri, Apr 27, 2018 at 2:10 PM, Greg Clayton via lldb-commits
> <lldb-commits at lists.llvm.org> wrote:
>> Author: gclayton
>> Date: Fri Apr 27 14:10:07 2018
>> New Revision: 331082
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=331082&view=rev
>> Log:
>> Fix build bots after r331049 broke them.
>>
>
> I would like to apologize for communicating this so late (mainly
> because I worked on the swift bits which are a little behind and I
> didn't update my checkout) but this commit completely broke debugging
> in some cases (on MacOS).
>
> Testcase:
>
> #import <Foundation/Foundation.h>
>
> int main() {
>   id keys[1] = { @"abc" };
>   id values[1] = { @"def" };
>   id d = CFBridgingRelease(CFDictionaryCreate(nil, (void *)keys, (void
> *)values, 1, nil, nil));
>   NSLog(@"%@", d);
>   NSLog(@"x");
> }
>
>
> $ clang patatino.m -framework Foundation -g -o blah
>
>
> dtdebugger2:bin davide$ ./lldb ./blah
> (lldb) target create "./blah"
> Current executable set to './blah' (x86_64).
> (lldb) b main
> Breakpoint 1: where = blah`main + 13 at blah.c:2, address =
> 0x0000000100000fad
> (lldb) r
> error: No such file or directory
>
> Reverting yours (and a later change to avoid conflicts):
>
> dtdebugger2:llvm-project-20170507 davide$ git revert 57dce7084e7b
> [master 8be66051362] Revert "Fixup r331049 (FileSpec
> auto-normalization)"
> 2 files changed, 11 insertions(+), 5 deletions(-)
> dtdebugger2:llvm-project-20170507 davide$ git revert
> d5a834a73c0b37c3862daee260c416e7ea3b761c
> [master 5bd1fb68a69] Revert "Fix build bots after r331049 broke them."
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> works.
> I also noticed that if I pass a full path the thing works:
>
> Current executable set to
> '/Users/davide/work/llvm-monorepo/build/bin/blah' (x86_64).
> (lldb) b main
> Breakpoint 1: where = blah`main + 13 at blah.c:2, address = 0x0000000100000fad
> (lldb) r
> Process 82833 launched:
> '/Users/davide/work/llvm-monorepo/build/bin/blah' (x86_64)
> Process 82833 stopped
> * thread #1, queue = 'com.apple.main-thread', stop reason = breakpoint 1.1
>     frame #0: 0x0000000100000fad blah`main at blah.c:2
>    1    int main(void) {
> -> 2      return 0;
>    3    }
>
>
> Do you mind to take a look and add a lit test for this?
>
> Thanks!
>
> --
> Davide