[Lldb-commits] [lldb] r331479 - Add back condition that was accidentally removed in r331462.
Greg Clayton via lldb-commits
lldb-commits at lists.llvm.org
Thu May 3 13:19:20 PDT 2018
Was this the "please make sure global variable expression can be evaluated when not running" issue you ran into?
> On May 3, 2018, at 1:13 PM, Adrian Prantl via lldb-commits <lldb-commits at lists.llvm.org> wrote:
>
> Author: adrian
> Date: Thu May 3 13:13:58 2018
> New Revision: 331479
>
> URL: http://llvm.org/viewvc/llvm-project?rev=331479&view=rev
> Log:
> Add back condition that was accidentally removed in r331462.
>
> This should make the bots much happier.
>
> Modified:
> lldb/trunk/source/Core/ValueObjectVariable.cpp
>
> Modified: lldb/trunk/source/Core/ValueObjectVariable.cpp
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Core/ValueObjectVariable.cpp?rev=331479&r1=331478&r2=331479&view=diff
> ==============================================================================
> --- lldb/trunk/source/Core/ValueObjectVariable.cpp (original)
> +++ lldb/trunk/source/Core/ValueObjectVariable.cpp Thu May 3 13:13:58 2018
> @@ -234,10 +234,12 @@ bool ValueObjectVariable::UpdateValue()
> // If this variable is a simple type, we read all data for it into
> // m_data. Make sure this type has a value before we try and read it
>
> - SymbolContext var_sc;
> - variable->CalculateSymbolContext(&var_sc);
> // If we have a file address, convert it to a load address if we can.
> - m_value.ConvertToLoadAddress(var_sc);
> + if (value_type == Value::eValueTypeFileAddress && process_is_alive) {
> + SymbolContext var_sc;
> + variable->CalculateSymbolContext(&var_sc);
> + m_value.ConvertToLoadAddress(var_sc);
> + }
>
> if (!CanProvideValue()) {
> // this value object represents an aggregate type whose children have
>
>
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
More information about the lldb-commits
mailing list