[Lldb-commits] [PATCH] D46395: Remove Process references from the Host module

[Pavel Labath via Phabricator via lldb-commits]

labath created this revision.
labath added reviewers: jingham, davide.
Herald added a subscriber: emaste.

The Process class was only being referenced because of the last-ditch
effort in the process launchers to set a process exit callback in case
one isn't set already.

Although launching a process for debugging is the most important kind of
"launch" we are doing, it is by far not the only one, so assuming this
particular callback is the one to be used is not a good idea (besides
breaking layering). Instead of assuming a particular exit callback, I
change the launcher code to require the callback to be set by the user (and fix
up the two call sites which did not set the callback already).


https://reviews.llvm.org/D46395

Files:
  source/Host/common/MonitoringProcessLauncher.cpp
  source/Host/common/NativeProcessProtocol.cpp
  source/Host/macosx/Host.mm
  source/Plugins/Platform/POSIX/PlatformPOSIX.cpp
  unittests/tools/lldb-server/tests/TestClient.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D46395.145037.patch
Type: text/x-patch
Size: 4533 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20180503/316a633b/attachment-0001.bin>