[Lldb-commits] [PATCH] D46334: [CMake] Unify and relayer testing

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added inline comments.


================
Comment at: test/CMakeLists.txt:101
   ${LLDB_SOURCE_DIR}/test/dotest.py
   "--no-multiprocess;${LLDB_DOTEST_ARGS}"
   "Testing LLDB with args: ${LLDB_DOTEST_ARGS}"
----------------
stella.stamenova wrote:
> LLDB_DOTEST_ARGS are passed here, but they were not in the generated project file when I tested this change. I suspect this has to do with setting the PARENT_SCOPE a couple of lines before. Why do we need that?
We need it in order to have the arguments available in the lit subdirectory. Did it work without the scope? We could eliminate the need for the `PARENT_SCOPE` by using a global property:

```
SET_PROPERTY(GLOBAL PROPERTY LLDB_DOTEST_ARGS_PROPERTY "${LLDB_DOTEST_ARGS}")
```
and
```
GET_PROPERTY(LLDB_DOTEST_ARGS GLOBAL PROPERTY LLDB_DOTEST_ARGS_PROPERTY)
```


https://reviews.llvm.org/D46334