[Lldb-commits] [PATCH] D46334: [lit] Make debugserver available to lit test

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova added inline comments.


================
Comment at: test/CMakeLists.txt:138
 if(CMAKE_HOST_APPLE)
-  list(APPEND LLDB_TEST_COMMON_ARGS --server ${DEBUGSERVER_PATH})
+  if (DEBUGSERVER_PATH STREQUAL "$<TARGET_FILE:debugserver>")
+    list(APPEND LLDB_EXECUTABLE_PATH_ARGS --server ${DEBUGSERVER_PATH})
----------------
JDevlieghere wrote:
> stella.stamenova wrote:
> > I am wondering if it's possible to make the logic here simpler. Since we need to handle each of the properties that can contain TARGET_FILE, it is starting to get rather complicated
> > 
> > I think you can actually use LLDB_DOTEST_ARGS_STR for the check-lldb-single target (since it creates a project that should be correctly substituted), so the only other place that could create issues is the lldb-dotest script. Since the tests are run as part of lit now, do we still need the lldb-dotest script?
> > 
> I started out that route, but how would that work for `check-lldb-single` with multiple targets? I'm not worried about `lldb-dotest`, we can do the same trick as for `llvm-lit`(see llvm/utils/llvm-lit/CMakeLists.txt). 
I cannot speak for other generators that support multiple configurations (though I suspect it is similar), but for Visual Studio, if the path to a tool contained CMAKE_CFG_INTDIR (which is $(Configuration)), when the project was built, $(Configuration) would be replaced with the configuration that is currently being used which is exactly what we want anyway.

Obviously, some additional testing will be required to verify that this is the case always.


Repository:
  rL LLVM

https://reviews.llvm.org/D46334