[Lldb-commits] [PATCH] D40470: DWZ 03/07: Protect DWARFCompileUnit::m_die_array by a new mutex

Greg Clayton via lldb-commits lldb-commits at lists.llvm.org
Tue May 1 09:23:51 PDT 2018


Good catch

> On May 1, 2018, at 1:19 AM, Pavel Labath via Phabricator <reviews at reviews.llvm.org> wrote:
> 
> labath added inline comments.
> 
> 
> ================
> Comment at: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:317
> void DWARFUnit::ClearDIEs(bool keep_compile_unit_die) {
>   if (m_die_array.size() > 1) {
> +    llvm::sys::ScopedWriter lock(m_extractdies_mutex);
> ----------------
> You're accessing m_die_array without holding a lock.
> 
> 
> Repository:
>  rL LLVM
> 
> https://reviews.llvm.org/D40470
> 
> 
> 



More information about the lldb-commits mailing list