[Lldb-commits] [PATCH] D46220: Remove premature caching of the global variables list in CompileUnit.

[Pavel Labath via Phabricator via lldb-commits]

labath added inline comments.


================
Comment at: lldb/trunk/packages/Python/lldbsuite/test/lang/c/global_variables/TestGlobalVariables.py:42
 
+        # Test that static initialized variables can be inspected without process.
+        self.expect("target variable g_ptr", VARIABLES_DISPLAYED_CORRECTLY,
----------------
this part wasn't correctly working for us on arm64, so I've split it off into a separate test, so we can still have coverage from the rest of the checks here. I think I managed to preserve the intent of your test, but you may want to have a quick look at the result (r331250).


================
Comment at: lldb/trunk/packages/Python/lldbsuite/test/lang/c/global_variables/TestGlobalVariables.py:63-65
+        self.runCmd("frame variable --show-types --scope --show-globals --no-args")
         self.expect(
             "frame variable --show-types --scope --show-globals --no-args",
----------------
Why do you need to run this command twice?


Repository:
  rL LLVM

https://reviews.llvm.org/D46220