[Lldb-commits] [PATCH] D46083: Move the persistent variable counter into Target

Jim Ingham via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Apr 30 15:48:25 PDT 2018

jingham added a comment.

Eh, must have. The page really shouldn't let you overall submit if there are uncommitted comments, but whatever.  Let's see if I did it right this time..

Comment at: source/Plugins/ExpressionParser/Clang/ClangUserExpression.cpp:668
 ConstString ClangUserExpression::ResultDelegate::GetName() {
-  return m_persistent_state->GetNextPersistentVariableName(*m_target_sp);
+  return m_persistent_state->GetNextPersistentVariableName(*m_target_sp, "$");
Don't hard-code "$" here, call GetPersistentVariablePrefix.


More information about the lldb-commits mailing list