[Lldb-commits] [PATCH] D46220: Remove premature caching of the global variables list in CompileUnit.

[Adrian Prantl via Phabricator via lldb-commits]

aprantl added inline comments.


================
Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:4221
               if (variable_list_sp.get() == NULL) {
                 variable_list_sp.reset(new VariableList());
               }
----------------
clayborg wrote:
> So do we cache now somewhere else now that "sc.comp_unit->SetVariableList(variable_list_sp);" is removed?
Yes,  CompileUnit::GetVariableList() grabs the *complete* list of variables via (SymbolFileDWARF, ...)::ParseVariablesForContext and that still calls sc.comp_unit->SetVariableList(variables); which acts as the caching mechanism.


https://reviews.llvm.org/D46220