[Lldb-commits] [PATCH] D46144: Reflow paragraphs in comments.

Adrian Prantl via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Apr 30 09:02:03 PDT 2018

aprantl added inline comments.

Comment at: source/Host/common/MainLoop.cpp:158
   // ppoll(2) is not supported on older all android versions. Also, older
-  // versions android (API <= 19) implemented pselect in a non-atomic way, as a
-  // combination of pthread_sigmask and select. This is not sufficient for us,
JDevlieghere wrote:
> Is this intentional or maybe an off-by-one error? The `a` is in the 79th colum, which is okay for clang-format. 
My script sets the threshold to 78 columns. When you are on an 80-column terminal and your editor doesn't indicate whether long lines continue or not then not using the last two characters makes it unambiguous whether the `a` is the beginning of a new word or whether it stands for itself.
I'll change the threshold to 80 columns to avoid reflowing paragraphs that don't need it.


More information about the lldb-commits mailing list