[Lldb-commits] [PATCH] D45977: Always normalize FileSpec paths.

[Greg Clayton via Phabricator via lldb-commits]

clayborg updated this revision to Diff 144021.
clayborg added a comment.

After doing performance tests, the code was 7 to 10 % slower if we didn't check if a path needs normalization due to the llvm code making arrays of StringRef objects and appending a path together. Restored and even improved performance after adding back the needsNormalization() function that quickly checks if a path needs normalization and avoids the splitting of the path and reconstruction of the path if it isn't needed.


https://reviews.llvm.org/D45977

Files:
  include/lldb/Core/FileSpecList.h
  include/lldb/Utility/FileSpec.h
  source/Breakpoint/BreakpointResolverFileLine.cpp
  source/Core/FileSpecList.cpp
  source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
  source/Plugins/SymbolFile/DWARF/DWARFDebugLine.cpp
  source/Plugins/SymbolFile/DWARF/DWARFDebugLine.h
  source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
  source/Symbol/CompileUnit.cpp
  source/Symbol/Declaration.cpp
  source/Utility/FileSpec.cpp
  unittests/Utility/FileSpecTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D45977.144021.patch
Type: text/x-patch
Size: 28605 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20180425/05eedfd7/attachment-0001.bin>