[Lldb-commits] [PATCH] D46083: Move the persistent variable counter into Target

[Adrian Prantl via Phabricator via lldb-commits]

aprantl created this revision.
aprantl added a reviewer: jingham.

Move the persistent variable counter into Target so it can be shared across multiple language plugins.

      

In a multi-language project it is counterintuitive to have a result
variables reuse numbers just because they are using a different
language plugin in LLDB (but not for example, when they are
Objective-C versus C++, since they are both handled by Clang).

      

This is NFC on llvm.org except for the Go plugin.

      

rdar://problem/39299889


https://reviews.llvm.org/D46083

Files:
  include/lldb/Expression/ExpressionVariable.h
  include/lldb/Target/Target.h
  source/Core/ValueObject.cpp
  source/Expression/Materializer.cpp
  source/Plugins/ExpressionParser/Clang/ClangPersistentVariables.cpp
  source/Plugins/ExpressionParser/Clang/ClangPersistentVariables.h
  source/Plugins/ExpressionParser/Clang/ClangUserExpression.cpp
  source/Plugins/ExpressionParser/Clang/ClangUserExpression.h
  source/Plugins/ExpressionParser/Go/GoUserExpression.cpp
  source/Plugins/ExpressionParser/Go/GoUserExpression.h
  source/Target/ABI.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D46083.144002.patch
Type: text/x-patch
Size: 8659 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20180425/f5737825/attachment.bin>