[Lldb-commits] [PATCH] D45700: Improve LLDB's handling of non-local minidumps

[Adrian McCarthy via Phabricator via lldb-commits]

amccarth accepted this revision.
amccarth added a comment.

I actually preferred the factory solution.

What I intended to express is that the modification of the target doesn't seems like it should be inside the PlaceholderModule class, so whether you use a factory or not doesn't really address that aspect of the coupling.  In my head, modification of the target should be done by the client that instantiates the PlaceholderModule (whether it does that via constructor or factory).

But this isn't a new problem, so I'm happy to consider the coupling problem outside the scope of this patch.


https://reviews.llvm.org/D45700