[Lldb-commits] [PATCH] D45703: Use a utility function to speed up "process load image" for POSIX Platforms
Jim Ingham via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue Apr 17 10:55:23 PDT 2018
jingham updated this revision to Diff 142800.
jingham added a comment.
Address review comments.
I changed over to passing a up to get stored in the process.
I separated the maker code into a separate function.
I changed GetPath versions (the buffer one was in the original, but I agree the std::string one is better.)
I didn't address the "changing platforms mid-stream" comment. If we want to make that a policy, I think it's better to do that separately.
I didn't add a general purpose facility to cache in the Process, since I don't have enough examples to know what to do there.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 17877 bytes
Desc: not available
More information about the lldb-commits