[Lldb-commits] [PATCH] D45703: Use a utility function to speed up "process load image" for POSIX Platforms

[Jim Ingham via Phabricator via lldb-commits]

jingham updated this revision to Diff 142800.
jingham added a comment.

Address review comments.

I changed over to passing a up to get stored in the process.
I separated the maker code into a separate function.
I changed GetPath versions (the buffer one was in the original, but I agree the std::string one is better.)
I didn't address the "changing platforms mid-stream" comment.  If we want to make that a policy, I think it's better to do that separately.
I didn't add a general purpose facility to cache in the Process, since I don't have enough examples to know what to do there.


Repository:
  rL LLVM

https://reviews.llvm.org/D45703

Files:
  include/lldb/Target/Process.h
  source/Plugins/Platform/POSIX/PlatformPOSIX.cpp
  source/Plugins/Platform/POSIX/PlatformPOSIX.h
  source/Target/Process.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D45703.142800.patch
Type: text/x-patch
Size: 17877 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20180417/bb8ba72a/attachment.bin>