[Lldb-commits] [PATCH] D45700: Improve LLDB's handling of non-local minidumps

[Greg Clayton via Phabricator via lldb-commits]

clayborg added a comment.

Looks good. I questions if we want PlaceholderModule to be available for all symbolicators/core dump plugins. See inlined comments.



================
Comment at: source/Plugins/Process/minidump/ProcessMinidump.cpp:47
+//------------------------------------------------------------------
+class PlaceholderModule : public Module {
+public:
----------------
I would be worth putting this class maybe in the same folder as lldb_private::Module and possibly renaming it. I can see this kind of thing being useful for symbolication in general and it won't be limited to use in minidumps. It should have enough accessors that allows an external client to modify everything.


================
Comment at: source/Plugins/Process/minidump/ProcessMinidump.cpp:79
+private:
+  SectionList m_sections;
+};
----------------
Just use lldb_private::Module::m_sections_ap and put the sections in there? Any reason not to?


https://reviews.llvm.org/D45700