[Lldb-commits] [PATCH] D45554: Make sure deleting all breakpoints clears their sites first
Greg Clayton via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Fri Apr 13 07:52:06 PDT 2018
clayborg added a comment.
In https://reviews.llvm.org/D45554#1066730, @eugene wrote:
> There is an ownership cycle between BreakpointSite::m_owners and BreakpointLocation::m_bp_site_sp.
> We should probably make m_owners a collection of weak references.
> But currently most of the code just works it around by calling Breakpoint::ClearAllBreakpointSites() before deleting a breakpoint.
Anytime there is a clear hierarchy we should use shared and weak pointers correctly. I would vote to fix this issue.
More information about the lldb-commits