[Lldb-commits] [PATCH] D45554: Make sure deleting all breakpoints clears their sites first
Davide Italiano via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Thu Apr 12 10:24:03 PDT 2018
davide added inline comments.
================
Comment at: packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_command/main.c:14-15
+ // This line adds a real body to the function, so we can set more than one
+ // breakpoint in it.
+ printf("Observable side effect\n");
return 0; // Set break point at this line.
----------------
davide wrote:
> you don't really need printf.
> You can just declare a set of few new fresh variables, one per line, I think.
The reason why I'm saying this is because this test doesn't really rely on `stdio.h` and I'd rather leave it as is.
https://reviews.llvm.org/D45554
More information about the lldb-commits
mailing list