[Lldb-commits] [PATCH] D45170: Cleanup DWARFCompileUnit and DWARFUnit in preparation for adding DWARFTypeUnit

[Jan Kratochvil via lldb-commits]

On Wed, 11 Apr 2018 00:53:20 +0200, Jan Kratochvil wrote:
> On Wed, 11 Apr 2018 00:22:45 +0200, Greg Clayton wrote:
> > If this is all in the same file, then the offsets are all in the
> > .debug_info? What am I missing?
> 
> LLVM was asserting when I reported the same lldb::user_id_t referenced by
> multiple CUs. From our discussion it looks to me that maybe I just did not
> have the DWZ common symbol file with proper offset. Otherwise maybe I can
> report the same lldb::user_id_t if multiple CUs reference the same DIE from
> DW_TAG_partial_unit? As LLVM considers all CUs in a file as the same context.
> I will try that again.

In such case if you are sure no real DIEs remapping (to make each inclusion of
DW_TAG_partial_unit unique) is needed then no remapping DWARFPartialUnit is
needed and your removal of my DWARFUnit abstraction by Data() (which
I incorrectly reverted) is also OK.

(Although I will believe it only after I code it; this is what I coded first
but I could have some other bugs there that time.)


Thanks,
Jan