[Lldb-commits] [PATCH] D45480: Move Args.cpp from Interpreter to Utility

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Apr 10 03:19:09 PDT 2018


labath created this revision.
labath added reviewers: zturner, jingham, davide.
Herald added a subscriber: mgorny.

The Args class is used in plenty of places besides the command
interpreter (e.g., anything requiring an argc+argv combo, such as when
launching a process), so it needs to be in a lower layer. Now that the
class has no external dependencies, it can be moved down to the Utility
module.

This removes the last (direct) dependency from the Host module to
Interpreter, so I remove the Interpreter module from Host's dependency
list.


https://reviews.llvm.org/D45480

Files:
  include/lldb/Interpreter/Args.h
  include/lldb/Interpreter/CommandAlias.h
  include/lldb/Interpreter/CommandInterpreter.h
  include/lldb/Interpreter/CommandObject.h
  include/lldb/Interpreter/Options.h
  include/lldb/Target/ProcessInfo.h
  include/lldb/Utility/Args.h
  source/API/SBDebugger.cpp
  source/API/SBPlatform.cpp
  source/API/SBProcess.cpp
  source/API/SBTarget.cpp
  source/Breakpoint/BreakpointIDList.cpp
  source/Commands/CommandCompletions.cpp
  source/Commands/CommandObjectApropos.cpp
  source/Commands/CommandObjectCommands.cpp
  source/Commands/CommandObjectFrame.cpp
  source/Commands/CommandObjectLog.cpp
  source/Commands/CommandObjectMemory.cpp
  source/Commands/CommandObjectPlatform.cpp
  source/Commands/CommandObjectProcess.cpp
  source/Commands/CommandObjectRegister.cpp
  source/Commands/CommandObjectTarget.cpp
  source/Core/RegisterValue.cpp
  source/Host/CMakeLists.txt
  source/Host/macosx/HostInfoMacOSX.mm
  source/Interpreter/Args.cpp
  source/Interpreter/CMakeLists.txt
  source/Interpreter/CommandInterpreter.cpp
  source/Interpreter/CommandObjectScript.cpp
  source/Interpreter/OptionValueArch.cpp
  source/Interpreter/OptionValueArgs.cpp
  source/Interpreter/OptionValueArray.cpp
  source/Interpreter/OptionValueDictionary.cpp
  source/Interpreter/OptionValueFileSpec.cpp
  source/Interpreter/OptionValueFileSpecLIst.cpp
  source/Interpreter/OptionValueLanguage.cpp
  source/Interpreter/OptionValuePathMappings.cpp
  source/Interpreter/OptionValueProperties.cpp
  source/Interpreter/OptionValueString.cpp
  source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptRuntime.cpp
  source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptScriptGroup.cpp
  source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.h
  source/Plugins/Process/gdb-remote/GDBRemoteCommunication.h
  source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
  source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp
  source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
  source/Utility/Args.cpp
  source/Utility/CMakeLists.txt
  tools/lldb-server/LLDBServerUtilities.cpp
  unittests/Interpreter/CMakeLists.txt
  unittests/Interpreter/TestArgs.cpp
  unittests/Utility/ArgsTest.cpp
  unittests/Utility/CMakeLists.txt
  unittests/tools/lldb-server/tests/MessageObjects.cpp
  unittests/tools/lldb-server/tests/TestClient.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D45480.141816.patch
Type: text/x-patch
Size: 31765 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20180410/4d96c8c2/attachment-0001.bin>


More information about the lldb-commits mailing list