[Lldb-commits] [lldb] r329296 - Remove unused NativeProcessProtocol.h include from Platform.h

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Thu Apr 5 08:17:52 PDT 2018

Author: labath
Date: Thu Apr  5 08:17:51 2018
New Revision: 329296

URL: http://llvm.org/viewvc/llvm-project?rev=329296&view=rev
Remove unused NativeProcessProtocol.h include from Platform.h

After removing it, I got a couple of compile errors because we were
missing some symbols (SIGKILL and such), as their definitions were not
transitively included anymore. I fix this by including csignal from
PosixApi.h, as it's windows version provides a stub definitions of these
symbols. This should make the result of #including PosixApi.h more
consistent across platforms (although in the long run, we should just
get rid of this header).


Modified: lldb/trunk/include/lldb/Host/PosixApi.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Host/PosixApi.h?rev=329296&r1=329295&r2=329296&view=diff
--- lldb/trunk/include/lldb/Host/PosixApi.h (original)
+++ lldb/trunk/include/lldb/Host/PosixApi.h Thu Apr  5 08:17:51 2018
@@ -18,6 +18,7 @@
 #include "lldb/Host/windows/PosixApi.h"
 #include <unistd.h>
+#include <csignal>

Modified: lldb/trunk/include/lldb/Target/Platform.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Target/Platform.h?rev=329296&r1=329295&r2=329296&view=diff
--- lldb/trunk/include/lldb/Target/Platform.h (original)
+++ lldb/trunk/include/lldb/Target/Platform.h Thu Apr  5 08:17:51 2018
@@ -30,10 +30,6 @@
 #include "lldb/lldb-private-forward.h"
 #include "lldb/lldb-public.h"
-// TODO pull NativeDelegate class out of NativeProcessProtocol so we
-// can just forward ref the NativeDelegate rather than include it here.
-#include "lldb/Host/common/NativeProcessProtocol.h"
 namespace lldb_private {
 class ModuleCache;

More information about the lldb-commits mailing list