[Lldb-commits] [PATCH] D45298: [debugserver] Fix LC_BUILD_VERSION load command handling.
Frederic Riss via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed Apr 4 16:05:30 PDT 2018
friss created this revision.
friss added reviewers: jasonmolenda, labath.
In one of the 2 places the LC_BUILD_VERSION load command is handled, there
is a bug preventing us from actually handling them (the address where to
read the load command was not updated). This patch factors reading the
deployment target load commands into a helper and adds testing for the 2
code paths calling the helper.
The testing is a llittle bit complicated because the only times those load
commands matter is when debugging a simulator process. I added a new
decorator to check that a specific SDK is available. The actual testing was
fairly easy once I knew how to run a simulated process.
Adding Pavel as a reviewer given I slightly modified the lldb-server test
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 21014 bytes
Desc: not available
More information about the lldb-commits