[Lldb-commits] [PATCH] D45298: [debugserver] Fix LC_BUILD_VERSION load command handling.

[Frederic Riss via Phabricator via lldb-commits]

friss created this revision.
friss added reviewers: jasonmolenda, labath.

In one of the 2 places the LC_BUILD_VERSION load command is handled, there
is a bug preventing us from actually handling them (the address where to
read the load command was not updated). This patch factors reading the
deployment target load commands into a helper and adds testing for the 2
code paths calling the helper.

The testing is a llittle bit complicated because the only times those load
commands matter is when debugging a simulator process. I added a new
decorator to check that a specific SDK is available. The actual testing was
fairly easy once I knew how to run a simulated process.

Adding Pavel as a reviewer given I slightly modified the lldb-server test
harness.


https://reviews.llvm.org/D45298

Files:
  packages/Python/lldbsuite/test/decorators.py
  packages/Python/lldbsuite/test/tools/lldb-server/TestAppleSimulatorOSType.py
  packages/Python/lldbsuite/test/tools/lldb-server/main.cpp
  tools/debugserver/source/DNB.cpp
  tools/debugserver/source/DNB.h
  tools/debugserver/source/MacOSX/MachProcess.h
  tools/debugserver/source/MacOSX/MachProcess.mm
  tools/debugserver/source/RNBRemote.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D45298.141083.patch
Type: text/x-patch
Size: 21014 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20180404/916a257a/attachment-0001.bin>