[Lldb-commits] [PATCH] D45215: RFC/WIP: Have lit run the lldb test suite

Zachary Turner via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Apr 4 11:30:19 PDT 2018

zturner added a comment.

In https://reviews.llvm.org/D45215#1057311, @labath wrote:

> > Preferably lit would take care of as much as possible. I think Zachary’s
> >  idea makes sense as an incremental step. If we think of one python file as
> >  a google test executable, it makes sense to return a list of test for every
> >  python file for “v2”. I think running the different variants as separate
> >  tests is going to be “v3” and will require quite a bit more work.
> Actually, this (v3) should happen pretty much automatically, as the test variant is encoded in the test method name. we have a python metaclass which does this replication for us, and as far as the rest of the world is concerned, they are just separate tests.
> So if you just normally enumerate all methods in a test class, you will naturally get every variant in it's own test.

Yea but there are some issues with that, such as wanting to have a bit of common set up for each directory so that each variant doesn't have to do the same expensive thing over and over.

Anyway, we should discuss this when it's time to actually implement that since I think there are some interesting cases to consider.


More information about the lldb-commits mailing list