clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Very nice. Thanks for doing this. Someone a while back had converted Scalar to use APInt and APFloat and never got around to all of these details. https://reviews.llvm.org/D44907